Merge pull request #14 from clearbit/rh-find-endpoint

src/enrichment.js

@@ -2,11 +2,10 @@
 
 var assert   = require('assert');
 var resource = require('./resource');
-var _        = require('lodash');
 var Company  = require('./enrichment/company');
 var Person   = require('./enrichment/person');
 
-exports.Enrichment = resource.create('Enrichment', {api: 'person'})
+exports.Enrichment = resource.create('Enrichment', {api: 'person', version: 2})
   .extend(null, {
     find: function(options){
       options = options || {};
@@ -16,10 +15,7 @@ exports.Enrichment = resource.create('Enrichment', {api: 'person'})
 
       assert(options.email, 'An email must be provided');
 
-      return this.get(
-        '/combined/email/' + options.email,
-        _.omit(options, 'email')
-      );
+      return this.get('/combined/find', options);
     },
 
     Company: Company,

src/enrichment/company.js

@@ -2,9 +2,8 @@
 
 var assert   = require('assert');
 var resource = require('../resource');
-var _        = require('lodash');
 
-exports.Company = resource.create('Company', {api: 'company'})
+exports.Company = resource.create('Company', {api: 'company', version: 2})
   .extend({
     flag: function(options){
       return this.constructor.post('/companies/' + this.id + '/flag', options);
@@ -15,9 +14,6 @@ exports.Company = resource.create('Company', {api: 'company'})
       options = options || {};
       assert(options.domain, 'A domain must be provided');
 
-      return this.get(
-        '/companies/domain/' + options.domain,
-        _.omit(options, 'domain')
-      );
+      return this.get('/companies/find', options);
     }
   });

src/enrichment/person.js

@@ -2,9 +2,8 @@
 
 var assert   = require('assert');
 var resource = require('../resource');
-var _        = require('lodash');
 
-exports.Person = resource.create('Person', {api: 'person'})
+exports.Person = resource.create('Person', {api: 'person', version: 2})
   .extend({
     flag: function(options){
       return this.constructor.post('/people/' + this.id + '/flag', options);
@@ -15,9 +14,6 @@ exports.Person = resource.create('Person', {api: 'person'})
       options = options || {};
       assert(options.email, 'An email must be provided');
 
-      return this.get(
-        '/people/email/' + options.email,
-        _.omit(options, 'email')
-      );
+      return this.get('/people/find', options);
     }
   });

test/company.js

@@ -21,7 +21,7 @@ describe('Company', function () {
 
     it('can find a company by domain', function () {
       mock
-        .get('/v1/companies/domain/uber.com')
+        .get('/v2/companies/find?domain=uber.com')
         .reply(200, company);
       return Company.find({domain: 'uber.com'})
         .then(function (company) {
@@ -32,9 +32,8 @@ describe('Company', function () {
     });
 
     it('can handle queued requests', function () {
-
       mock
-        .get('/v1/companies/domain/uber.com')
+        .get('/v2/companies/find?domain=uber.com')
         .reply(202, {
           error: {
             type: 'queued'
@@ -46,7 +45,7 @@ describe('Company', function () {
 
     it('can handle unknown records', function () {
       mock
-        .get('/v1/companies/domain/nonexistent.co')
+        .get('/v2/companies/find?domain=nonexistent.co')
         .reply(404, {
           error: {
             type: 'unknown_record'

test/person.js

@@ -23,7 +23,7 @@ describe('Person', function () {
 
     it('can find a person by email', function () {
       mock
-        .get('/v1/people/email/alex@alexmaccaw.com')
+        .get('/v2/people/find?email=alex%40alexmaccaw.com')
         .reply(200, alex);
       return Person.find({email: 'alex@alexmaccaw.com'})
         .then(function (person) {
@@ -35,14 +35,14 @@ describe('Person', function () {
 
     it('can subscribe to a person', function () {
       mock
-        .get('/v1/people/email/alex@alexmaccaw.com?subscribe=true')
+        .get('/v2/people/find?email=alex%40alexmaccaw.com&subscribe=true')
         .reply(200, alex);
       return Person.find({email: 'alex@alexmaccaw.com', subscribe: true});
     });
 
     it('can handle queued requests', function () {
       mock
-        .get('/v1/people/email/alex@alexmaccaw.com')
+        .get('/v2/people/find?email=alex%40alexmaccaw.com')
         .reply(202, {
           error: {
             type: 'queued'
@@ -54,7 +54,7 @@ describe('Person', function () {
 
     it('can handle unknown records', function () {
       mock
-        .get('/v1/people/email/bademail@unknown.com')
+        .get('/v2/people/find?email=bademail%40unknown.com')
         .reply(404, {
           error: {
             type: 'unknown_record'
@@ -70,7 +70,7 @@ describe('Person', function () {
 
     it('can find a person by email', function () {
       mock
-        .get('/v1/combined/email/alex@alexmaccaw.com')
+        .get('/v2/combined/find?email=alex%40alexmaccaw.com')
         .reply(200, {
           person: alex,
           company: company
@@ -86,7 +86,7 @@ describe('Person', function () {
 
     it('can handle queued requests', function () {
       mock
-        .get('/v1/combined/email/alex@alexmaccaw.com')
+        .get('/v2/combined/find?email=alex%40alexmaccaw.com')
         .reply(202, {
           error: {
             type: 'queued'
@@ -99,4 +99,3 @@ describe('Person', function () {
   });
 
 });
-